Re: [Qemu-devel] [PATCH 09/11] target-i386/cpu: Name new CPUID bits

[Eduardo Habkost]

On Mon, Nov 26, 2012 at 04:30:41PM +0100, Igor Mammedov wrote:
> Eduardo,
> 
> While doing rebase of x86 cpu properties on top of the current master, I've
> stumbled on possibly removed by mistake cpuid feature, pls see inline
> 
> On Thu, 15 Nov 2012 04:06:45 +0100
> Andreas Färber <address@hidden> wrote:
> 
> ...
> > @@ -87,10 +87,10 @@ static const char *ext3_feature_name[] = {
> >      "lahf_lm" /* AMD LahfSahf */, "cmp_legacy", "svm", "extapic" /* AMD 
> > ExtApicSpace */,
> >      "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
> >      "3dnowprefetch", "osvw", "ibs", "xop",
> > -    "skinit", "wdt", NULL, NULL,
> > -    "fma4", NULL, "cvt16", "nodeid_msr",
>                       ^^^^
> > -    NULL, NULL, NULL, NULL,
> > -    NULL, NULL, NULL, NULL,
> > +    "skinit", "wdt", NULL, "lwp",
> > +    "fma4", "tce", NULL, "nodeid_msr",
>                       ^^^^  should we keep cvt16 here ?
> > +    NULL, "tbm", "topoext", "perfctr_core",
> > +    "perfctr_nb", NULL, NULL, NULL,
> >      NULL, NULL, NULL, NULL,
> >  };
> ...
> 
> it's committed as: c8acc380: target-i386/cpu: Name new CPUID bits

It was on purpose. See
<http://article.gmane.org/gmane.comp.emulators.qemu/176694>.

This should have been documented on the commit message, but I didn't
notice that the patch from Boris that I resubmitted in November was the
same one where I asked for a commit message change in October.

-- 
Eduardo