[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] sclp: Fix uninitialized var in handle_write_eve
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 2/2] sclp: Fix uninitialized var in handle_write_event_buf(). |
Date: |
Mon, 26 Nov 2012 20:17:42 +0100 |
From: Cornelia Huck <address@hidden>
Some gcc versions rightly complain about a possibly unitialized rc,
so let's move setting it before the QTAILQ_FOREACH().
Signed-off-by: Cornelia Huck <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
hw/s390x/event-facility.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index 9367660..bc9cea9 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -112,12 +112,13 @@ static uint16_t handle_write_event_buf(SCLPEventFacility
*ef,
SCLPEvent *event;
SCLPEventClass *ec;
+ rc = SCLP_RC_INVALID_FUNCTION;
+
QTAILQ_FOREACH(kid, &ef->sbus.qbus.children, sibling) {
DeviceState *qdev = kid->child;
event = (SCLPEvent *) qdev;
ec = SCLP_EVENT_GET_CLASS(event);
- rc = SCLP_RC_INVALID_FUNCTION;
if (ec->write_event_data &&
ec->event_type() == event_buf->type) {
rc = ec->write_event_data(event, event_buf);
--
1.6.0.2