[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman |
Date: |
Mon, 26 Nov 2012 21:09:47 +0100 |
On 26.11.2012, at 21:04, Gerd Hoffmann wrote:
> Hi,
>
>> Guard the PIXMAN_TYPE_BGRA branch like in the case right above the failing
>> case, so that compilation is fixed. Functionality on such old pixman is a
>> different question ;-).
>
>> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
>> type = PIXMAN_TYPE_BGRA;
>> +#endif
>
> Version is wrong, on 0.18.4 this builds just fine, so PIXMAN_TYPE_BGRA
> must be older than that.
>
> I'd also tend to just change the check in configure instead and ignore
> system pixman in case it is too old.
Ah, I just copied the check from 5 lines above :).
Alex