[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device <not-
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device <not-a-device-type> |
Date: |
Wed, 28 Nov 2012 07:18:38 -0500 (EST) |
> Il 28/11/2012 12:54, Luiz Capitulino ha scritto:
> > On Wed, 28 Nov 2012 10:54:33 +0200
> > Alon Levy <address@hidden> wrote:
> >
> >> Instead of aborting immediately after at DEVICE_CLASS(obj)
> >>
> >> Signed-off-by: Alon Levy <address@hidden>
> >> ---
> >> hw/qdev-monitor.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
> >> index 479eecd..3b70cdb 100644
> >> --- a/hw/qdev-monitor.c
> >> +++ b/hw/qdev-monitor.c
> >> @@ -426,6 +426,11 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> >> return NULL;
> >> }
> >>
> >> + if (!object_class_dynamic_cast(obj, "device")) {
> >> + qerror_report(QERR_INVALID_PARAMETER_TYPE, "driver",
> >> "device type");
> >> + return NULL;
> >> + }
> >
> > Gives me the impression that something is wrong before this, but
> > it's
> > better to ask a QOM guy (CC'ing them).
>
> I would reuse the same error message as for "if (!obj)", and also use
> TYPE_DEVICE instead of the hardcoded string, but the patch is ok.
>
> > How do you reproduce it btw?
>
> $ x86_64-softmmu/qemu-system-x86_64 -device SCSI
> Object 0x7f56872248b0 is not an instance of type device
> Aborted
>
> However, we also need an object_class_is_abstract method to fix this
> similar failure:
>
> $ x86_64-softmmu/qemu-system-x86_64 -device pci-device
> **
> ERROR:/home/pbonzini/work/upstream/qemu/qom/object.c:306:object_initialize_with_type:
> assertion failed: (type->abstract == false)
> Aborted
>
> All in all, it makes sense to me that we delay this post-1.3.
I agree, I'll keep it until then.
>
> Paolo
>
> >> +
> >> k = DEVICE_CLASS(obj);
> >>
> >> /* find bus */
> >
>
>
>
Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device <not-a-device-type>, Markus Armbruster, 2012/11/28