Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

[Konrad Frederic]

On 29/11/2012 14:09, Peter Maydell wrote:
> On 29 November 2012 12:37, Konrad Frederic<address@hidden>  wrote:
> > On 26/11/2012 17:59, Anthony Liguori wrote:
> > > virtio-pci-bus extends virtio-bus
> > >    - is constructed with a pointer to a PCIDevice
> > >    - implements the methods necessary to be a virtio bus
> > I still have trouble with that ^^.
> > The problem is that the virtio devices can't be connected to the
> > virtio-pci-bus even if it extends virtio-bus because TYPE_VIRTIO_BUS !=
> > TYPE_VIRTIO_PCI_BUS.
> Conceptually it ought to work I think: if the bus is-a TYPE_VIRTIO_BUS
> then we should permit plugging in even if the actual bus object happens
> to be an instance of a subclass.
Yes, is my implementation doing the right thing ?
I mean is the virtio-pci-bus a virtio-bus ?

> I suspect that qbus_find_recursive should be doing an
> object_class_dynamic_cast() to check that the bus is of a suitable
> type, rather than the
>      (strcmp(object_get_typename(OBJECT(bus)), bus_typename) != 0)
> which it does at the moment.
Yes, but we can cast VIRTIO_BUS in BUS no ?
So in this case we could plug VirtioDevice in BUS and that's not what we 
want ?

> -- PMM