[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane |
|
Date: |
Thu, 29 Nov 2012 16:09:28 +0200 |
On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote:
> Michael, Paolo: Are you happy with v4?
Looks pretty clean by itself. I sent some comments but they can be
addressed later. What worries me most is the code duplication with
regular virtio.
I see two ways to reduce the maintainance somewhat
- split out ring handling code in virtio-blk
to a separate file to make it more obvious which part
is inactive when data plane runs.
- share ring processing code with virtio/virtio-blk
(e.g. use callbacks)
Was any thought given to implementing one of these two
approaches?
--
MST
- Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code, (continued)
[Qemu-devel] [PATCH v4 09/11] iov: add qemu_iovec_concat_iov(), Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 08/11] test-iov: add iov_discard() testcase, Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 11/11] virtio-blk: add x-data-plane=on|off performance feature, Stefan Hajnoczi, 2012/11/22
Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/11/29