[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code |
Date: |
Thu, 29 Nov 2012 10:17:37 -0500 (EST) |
> > +/* Toggle guest->host notifies */
> > +void vring_set_notification(VirtIODevice *vdev, Vring *vring, bool
> > enable)
> > +{
> > + if (vdev->guest_features & (1 << VIRTIO_RING_F_EVENT_IDX)) {
> > + if (enable) {
> > + vring_avail_event(&vring->vr) = vring->vr.avail->idx;
> > + }
> > + } else if (enable) {
> > + vring->vr.used->flags &= ~VRING_USED_F_NO_NOTIFY;
> > + } else {
> > + vring->vr.used->flags |= VRING_USED_F_NO_NOTIFY;
> > + }
> > +}
This is similar to the (guest-side) virtqueue_disable_cb/virtqueue_enable_cb.
Perhaps having two functions will be easier to use, because from your
other code it looks like you'd benefit from a return value when
enable == true (again similar to virtqueue_enable_cb).
Paolo
- Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code, (continued)
Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code, Michael S. Tsirkin, 2012/11/29
[Qemu-devel] [PATCH v4 01/11] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane, Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code, Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 05/11] dataplane: add event loop, Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 07/11] iov: add iov_discard() to remove data, Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 06/11] dataplane: add Linux AIO request queue, Stefan Hajnoczi, 2012/11/22
[Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code, Stefan Hajnoczi, 2012/11/22