Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

[Auld, Will]

Marcelo, 

My latest QEMU patch ([PATCH V5] target-i386: Enabling IA32_TSC_ADJUST for QEMU 
KVM guest VMs) seems to be OK with regards to reset. The tsc_adjust variable is 
being zeroed by the memset() in x86_cpu_reset(). Later code seems to write 
these values through kvm_put_msr() by way of cpu_synchronize_all_post_reset(). 

Andreas said: I'm expecting this to go through Marcello's queue unless I'm told 
otherwise.

Does this meet your expectations as well?

Thanks,

Will

> -----Original Message-----
> From: Marcelo Tosatti [mailto:address@hidden
> Sent: Thursday, November 29, 2012 12:44 PM
> To: Auld, Will
> Cc: address@hidden; Dugger, Donald D; Liu, Jinsong; Zhang,
> Xiantao; address@hidden; qemu-devel; Gleb
> Subject: Re: [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM
> support
> 
> On Thu, Nov 29, 2012 at 07:21:28PM +0000, Auld, Will wrote:
> > Marcelo,
> >
> > The behavior on reset is to return the TSC_AJUST msr value to 0x0. I
> am currently initializing this emulated msr in kvm_arch_vcpu_init().
> 
> Will,
> 
> Reset is handled by QEMU. kvm_arch_vcpu_init is only called during vcpu
> allocation (ie vm creation). See x86_cpu_reset in QEMU's target-
> i386/cpu.c file.
> 
> >
> > >- Behaviour on reset: what is the behaviour on RESET?
> >
> > I am testing the rebase now. I would like to get any needed changes
> for this initialization into my next patch set version (v6) if
> possible.
> 
> For the kernel patch, everything is fine. Apparently for the QEMU patch
> it is  necessary to set value to zero on reset.