[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] qmp: qmp_drive_mirror(): pass Error object to b
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 5/6] qmp: qmp_drive_mirror(): pass Error object to bdrv_img_create() |
Date: |
Fri, 30 Nov 2012 10:52:08 -0200 |
Signed-off-by: Luiz Capitulino <address@hidden>
---
blockdev.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index cc9692d..6b293fe 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1264,8 +1264,8 @@ void qmp_drive_mirror(const char *device, const char
*target,
assert(format && drv);
bdrv_get_geometry(bs, &size);
size *= 512;
- ret = bdrv_img_create(target, format,
- NULL, NULL, NULL, size, flags, NULL);
+ bdrv_img_create(target, format,
+ NULL, NULL, NULL, size, flags, &local_err);
} else {
switch (mode) {
case NEW_IMAGE_MODE_EXISTING:
@@ -1273,18 +1273,18 @@ void qmp_drive_mirror(const char *device, const char
*target,
break;
case NEW_IMAGE_MODE_ABSOLUTE_PATHS:
/* create new image with backing file */
- ret = bdrv_img_create(target, format,
- source->filename,
- source->drv->format_name,
- NULL, -1, flags, NULL);
+ bdrv_img_create(target, format,
+ source->filename,
+ source->drv->format_name,
+ NULL, -1, flags, &local_err);
break;
default:
abort();
}
}
- if (ret) {
- error_set(errp, QERR_OPEN_FILE_FAILED, target);
+ if (error_is_set(&local_err)) {
+ error_propagate(errp, local_err);
return;
}
--
1.8.0
- [Qemu-devel] [PATCH v3 0/6] block: bdrv_img_create(): propagate errors, Luiz Capitulino, 2012/11/30
- [Qemu-devel] [PATCH 4/6] qmp: qmp_transaction(): pass Error object to bdrv_img_create(), Luiz Capitulino, 2012/11/30
- [Qemu-devel] [PATCH 1/6] block: bdrv_img_create(): add Error ** argument, Luiz Capitulino, 2012/11/30
- [Qemu-devel] [PATCH 2/6] qemu-img: img_create(): pass Error object to bdrv_img_create(), Luiz Capitulino, 2012/11/30
- [Qemu-devel] [PATCH 3/6] qemu-img: img_create(): drop unneeded goto and ret variable, Luiz Capitulino, 2012/11/30
- [Qemu-devel] [PATCH 5/6] qmp: qmp_drive_mirror(): pass Error object to bdrv_img_create(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 6/6] block: bdrv_img_create(): drop unused error handling code, Luiz Capitulino, 2012/11/30
- Re: [Qemu-devel] [PATCH v3 0/6] block: bdrv_img_create(): propagate errors, Kevin Wolf, 2012/11/30