[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amou
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read |
Date: |
Fri, 30 Nov 2012 14:25:43 +0100 |
The current code waits until the chardev can read MIN(len, VMC_MAX)
But some chardev may never reach than amount, in fact some of them
will only ever accept write of 1. Fix the min computation and remove
the VMC_MAX constant.
Signed-off-by: Marc-André Lureau <address@hidden>
---
spice-qemu-char.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 09aa22d..665efd3 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -14,8 +14,6 @@
} \
} while (0)
-#define VMC_MAX_HOST_WRITE 2048
-
typedef struct SpiceCharDriver {
CharDriverState* chr;
SpiceCharDeviceInstance sin;
@@ -35,8 +33,8 @@ static int vmc_write(SpiceCharDeviceInstance *sin, const
uint8_t *buf, int len)
uint8_t* p = (uint8_t*)buf;
while (len > 0) {
- last_out = MIN(len, VMC_MAX_HOST_WRITE);
- if (qemu_chr_be_can_write(scd->chr) < last_out) {
+ last_out = MIN(len, qemu_chr_be_can_write(scd->chr));
+ if (last_out <= 0) {
break;
}
qemu_chr_be_write(scd->chr, p, last_out);
--
1.7.11.7
- [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev, Marc-André Lureau, 2012/11/30
- [Qemu-devel] [PATCH 1/6] qemu-char: add qemu_chr_remove_clients(), Marc-André Lureau, 2012/11/30
- [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 3/6] spice-qemu-char: factor out CharDriverState creation, Marc-André Lureau, 2012/11/30
- [Qemu-devel] [PATCH 4/6] spice-qemu-char: add spiceport chardev, Marc-André Lureau, 2012/11/30
- [Qemu-devel] [PATCH 5/6] spice-qemu-char: keep a list of spice chardev, Marc-André Lureau, 2012/11/30
- [Qemu-devel] [PATCH 6/6] spice-qemu-char: register spicevmc ports during qemu_spice_init(), Marc-André Lureau, 2012/11/30
- Re: [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev, Gerd Hoffmann, 2012/11/30