[Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

[Andreas Färber]

Hello,

Some review comments for SysBus EHCI were ignored in favor of merging into 1.3.
As requested by Gerd, this now follows up with the cleanups I had requested
from Peter C. Apart from using the new-style QOM casts it also achieves some
deduplification. It then goes on to implement the suggested more slim way to
have different capsbase and opregbase values; the alternative would be to
create a new struct SysBusEHCIInfo for declarative initialization. Given that
there are only few models for now, the imperative approach allows for more
flexibility such as inheritence when, e.g., an Exynos 5 model varies only
slightly from Exynos 4.

Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a
new patch of mine to prepare a Tegra 2 EHCI device (cf. my tegra branch) to
show how this works out.

Regards,
Andreas

Changes from Liming Wang's patchset:
* Introduce abstract sysbus-ehci-usb and pci-ehci-usb types
* Move class_init / instance_init to base type as far as possible
* Use TYPE_* constant for instantiating exynos4210 EHCI
* Added my tegra2 SysBus EHCI device to the mix

Cc: Gerd Hoffmann <address@hidden>
Cc: Peter A. G. Crosthwaite <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: Igor Mitsyanko <address@hidden>
Cc: Liming Wang <address@hidden>
Cc: Vincent Palatin <address@hidden>

Andreas Färber (4):
  usb/ehci: Clean up SysBus and PCI EHCI split
  usb/ehci: Move capsbase and opregbase into SysBus EHCI class
  usb/ehci: Add SysBus EHCI device for Exynos4210
  usb/ehci: Add Tegra2 SysBus EHCI device

Liming Wang (1):
  exynos4210: Add EHCI support

 hw/exynos4210.c          |    7 +++++
 hw/exynos4210_gic.c      |    2 +-
 hw/usb/hcd-ehci-pci.c    |   37 ++++++++++++++++------
 hw/usb/hcd-ehci-sysbus.c |   76 ++++++++++++++++++++++++++++++++++++++++++----
 hw/usb/hcd-ehci.h        |    2 ++
 5 Dateien geändert, 108 Zeilen hinzugefügt(+), 16 Zeilen entfernt(-)

-- 
1.7.10.4