[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState |
Date: |
Sun, 02 Dec 2012 05:56:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Am 02.12.2012 05:50, schrieb Andreas Färber:
> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h
> index 61b7698..6c66fc0 100644
> --- a/include/qemu/cpu.h
> +++ b/include/qemu/cpu.h
> @@ -77,6 +77,10 @@ struct CPUState {
> bool stop;
> bool stopped;
>
> +#if !defined(CONFIG_USER_ONLY)
> + int kvm_fd;
> +#endif
> +
> /* TODO Move common fields from CPUArchState here. */
> };
>
First nit found myself: I strive to set good examples, so this field
addition should've been accompanied by a documentation update. ;)
I'll defer a v2 until other people have had a chance to review though.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH qom-cpu 00/11] QOM CPUState, part 6: CPU_COMMON for KVM, Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState, Andreas Färber, 2012/12/01
- Re: [Qemu-devel] [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState,
Andreas Färber <=
- [Qemu-devel] [PATCH qom-cpu 02/11] kvm: Pass CPUState to kvm_arch_*, Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 04/11] ppc: Pass PowerPCCPU to ppc_set_irq(), Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 05/11] ppc: Pass PowerPCCPU to [h]decr callbacks, Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 06/11] ppc: Pass PowerPCCPU to [h]decr timer callbacks, Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 07/11] ppc_booke: Pass PowerPCCPU to {decr, fit, wdt} timer callbacks, Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 08/11] ppc4xx_devs: Return PowerPCCPU from ppc4xx_init(), Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 03/11] kvm: Pass CPUState to kvm_vcpu_ioctl(), Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 09/11] ppc_booke: Pass PowerPCCPU to ppc_booke_timers_init(), Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 11/11] cpu: Move kvm_run into CPUState, Andreas Färber, 2012/12/01
- [Qemu-devel] [PATCH qom-cpu 10/11] cpu: Move kvm_state field into CPUState, Andreas Färber, 2012/12/01