Re: [Qemu-devel] [PATCH 1.3] ehci-sysbus: Attach DMA context.

[walimis]

On Thu, Nov 29, 2012 at 12:05:14PM +1000, Peter Crosthwaite wrote:
>On Thu, Nov 29, 2012 at 12:00 PM, walimis <address@hidden> wrote:
>> On Thu, Nov 29, 2012 at 11:43:18AM +1000, Peter Crosthwaite wrote:
>>>This was left as NULL on the initial merge due to debate on the mailing list 
>>>on
>>>how to handle DMA contexts for sysbus devices. Patch
>>>9e11908f12f92e31ea94dc2a4c962c836cba9f2a was later merged to fix OHCI. This 
>>>is the,
>>>equivalent fix for sysbus EHCI.
>>
>> I have also found this issue, but it's not the cause that xilinx
>> ehci can't work with usb-storage disk. Do you have any update
>> for xilinx ehci?
>>
>
>Hi Liming,
>
>I haven't got around to looking into that one yet unfortunately. No
>updates just yet - ill let you know if it resolves. It could very well
>be a Linux bug as well so it needs to be investigated from both sides
>of the fence.

As said in another mail, I found that the root cause is that xilinx_zynq has
two EHCI controller. If we use usb-storage disk, the disk will be attached to
the second EHCI controller, which the kernel uses the first EHCI controller
by default.

For now, qemu doesn't support two EHCI controller, could we remove the second
EHCI from xilinx_zynq?

Liming Wang

>
>>>
>>>Signed-off-by: Peter Crosthwaite <address@hidden>
>>
>> Tested-by: Liming Wang <address@hidden>
>>
>
>Thanks.
>
>Regards,
>Peter
>
>> Liming Wang
>>
>>>---
>>> hw/usb/hcd-ehci-sysbus.c |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>>diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c
>>>index 1584079..803df92 100644
>>>--- a/hw/usb/hcd-ehci-sysbus.c
>>>+++ b/hw/usb/hcd-ehci-sysbus.c
>>>@@ -45,6 +45,7 @@ static int usb_ehci_sysbus_initfn(SysBusDevice *dev)
>>>
>>>     s->capsbase = 0x100;
>>>     s->opregbase = 0x140;
>>>+    s->dma = &dma_context_memory;
>>>
>>>     usb_ehci_initfn(s, DEVICE(dev));
>>>     sysbus_init_irq(dev, &s->irq);
>>>--
>>>1.7.0.4
>>>
>>>
>>