qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5] Add compare subcommand for qemu-img


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v5] Add compare subcommand for qemu-img
Date: Tue, 4 Dec 2012 16:22:10 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 04, 2012 at 06:06:55AM -0500, Miroslav Rezanina wrote:
> +    for (;;) {
> +        c = getopt(argc, argv, "pf:F:sq");
> +        if (c == -1) {
> +            break;
> +        }
> +        switch (c) {
> +        case 'f':
> +            fmt1 = optarg;
> +            break;
> +        case 'F':
> +            fmt2 = optarg;
> +            break;
> +        case 'p':
> +            progress = 1;
> +            break;
> +        case 'q':
> +            quiet = 1;
> +            break;
> +        case 's':
> +            strict = 1;
> +            break;
> +        }
> +    }

Still missing '?' and 'h'.  They should call help().

Without this an invalid command-line option doesn't abort execution and
weird things can happen :).

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]