[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register. |
|
Date: |
Tue, 4 Dec 2012 17:42:09 +0000 |
On 2 December 2012 17:14, Antoine Mathys <address@hidden> wrote:
> Per the datasheet, the mapping between 12 and 24 hours modes is:
> 0 <-> 12 PM
> 1-12 <-> 1-12 AM
> 13-23 <-> 1-11 PM
>
> Signed-off-by: Antoine Mathys <address@hidden>
This looks good as far as the logic goes, but I think we
could use some symbolic constants for the 12-hour and PM
bits rather than all the literal 0x20 0x40 0x60.
thanks
-- PMM