[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state |
|
Date: |
Tue, 4 Dec 2012 21:50:37 +0000 |
On 4 December 2012 21:39, Richard Henderson <address@hidden> wrote:
> On 2012-12-04 15:25, Peter Maydell wrote:
>> So this is just a refactoring, but it prompts me to ask -- how does
>> this work if the PC that caused us to take this TLB fill is legitimately
>> zero? We seem to be overloading retaddr==0 as a "not a real cpu fault"
>> indicator...
>
> Since this is a host code address, usually inside code_gen_buffer,
> not a target code address, this isn't ever going to happen.
Oh, right. I was confused by the fact we're keeping it in a uintptr_t
rather than a void*.
-- PMM
- [Qemu-devel] [PATCH 0/4] exec.c refactoring, Blue Swirl, 2012/12/04
- [Qemu-devel] [PATCH 2/4] exec: extract TB watchpoint check, Blue Swirl, 2012/12/04
- [Qemu-devel] [PATCH 3/4] exec: move TB handling to translate-all.c, Blue Swirl, 2012/12/04
- [Qemu-devel] [PATCH 1/4] exec: fix coding style, Blue Swirl, 2012/12/04
- [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state, Blue Swirl, 2012/12/04
- Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state, Andreas Färber, 2012/12/05
- Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state, Aurelien Jarno, 2012/12/06