qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO a


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV
Date: Wed, 5 Dec 2012 15:49:51 +0000

On 5 December 2012 15:36, Richard Henderson <address@hidden> wrote:
> On 2012-12-04 17:29, Petar Jovanovic wrote:
>>      rs5_0 = (int8_t)(rs5_0 << 2) >> 2;
>
> This is more portably written as
>
>   rs5_0 = (rs5_0 ^ 0x20) - 0x20;

...but way more obscurely. If we want to play that
kind of game can we have a sign-extension function in
a header somewhere?

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]