[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/11] qdev: add reference count to a device for the
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 04/11] qdev: add reference count to a device for the BusChild |
Date: |
Wed, 5 Dec 2012 21:44:35 +0100 |
Each device has a reference through the BusChild. This reference
was not accounted for, add it now.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/qdev.c b/hw/qdev.c
index e758131..87dfcb5 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -65,7 +65,10 @@ static void bus_remove_child(BusState *bus, DeviceState
*child)
snprintf(name, sizeof(name), "child[%d]", kid->index);
QTAILQ_REMOVE(&bus->children, kid, sibling);
+
+ /* This gives back ownership of kid->child back to us. */
object_property_del(OBJECT(bus), name, NULL);
+ object_unref(OBJECT(kid->child));
g_free(kid);
return;
}
@@ -83,9 +86,11 @@ static void bus_add_child(BusState *bus, DeviceState *child)
kid->index = bus->max_index++;
kid->child = child;
+ object_ref(OBJECT(kid->child));
QTAILQ_INSERT_HEAD(&bus->children, kid, sibling);
+ /* This transfers ownership of kid->child to the property. */
snprintf(name, sizeof(name), "child[%d]", kid->index);
object_property_add_link(OBJECT(bus), name,
object_get_typename(OBJECT(child)),
--
1.8.0.1
- [Qemu-devel] [PATCH 00/11] qdev: correct reference counting, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 01/11] qdev: export and use qbus_init, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 02/11] qdev: use object_new, not g_malloc to create buses, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 03/11] qom: preserve object while unparenting it, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 04/11] qdev: add reference count to a device for the BusChild,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/11] qdev: move deletion of children from finalize to unparent, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 06/11] qdev: move unrealization of devices from finalize to unparent, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 07/11] qdev: add reference for the bus while it is referred to by the DeviceState, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 08/11] qdev: inline object_delete into qbus_free/qdev_free, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 09/11] qdev: drop extra references at creation time, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 11/11] qom: remove object_delete, Paolo Bonzini, 2012/12/05
- [Qemu-devel] [PATCH 10/11] cpu: do not use object_delete, Paolo Bonzini, 2012/12/05
- Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting, Paolo Bonzini, 2012/12/17