[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/13] qdev: qdev_create(): use error_report() inste
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH 09/13] qdev: qdev_create(): use error_report() instead of hw_error() |
Date: |
Thu, 6 Dec 2012 10:06:53 +0100 |
From: Eduardo Habkost <address@hidden>
hw_error() is specific for fatal hardware emulation errors, not for
internal errors related to the qdev object/class abstraction or object
initialization.
Replace it with an error_report() call, followed by abort().
This will also help reduce dependencies of the qdev code (as hw_error()
is from cpus.o, and depends on the CPU list from exec.o).
Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
hw/qdev.c | 8 +++++---
1 Datei geändert, 5 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 788b4da..599382c 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -109,10 +109,12 @@ DeviceState *qdev_create(BusState *bus, const char *name)
dev = qdev_try_create(bus, name);
if (!dev) {
if (bus) {
- hw_error("Unknown device '%s' for bus '%s'\n", name,
- object_get_typename(OBJECT(bus)));
+ error_report("Unknown device '%s' for bus '%s'\n", name,
+ object_get_typename(OBJECT(bus)));
+ abort();
} else {
- hw_error("Unknown device '%s' for default sysbus\n", name);
+ error_report("Unknown device '%s' for default sysbus\n", name);
+ abort();
}
}
--
1.7.10.4
- [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 02/13] user: Rename qemu-types.h to qemu-user-types.h, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 04/13] qapi/qmp-registry.c: Include headers it needs, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 06/13] qlist.h: Do not include qemu-common.h, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 01/13] user: Move *-user/qemu-types.h to main directory, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 03/13] ui/vnc-palette.c: Include headers it needs, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 11/13] target-i386: Separate feature string parsing from CPU model lookup, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 05/13] qga/channel-posix.c: Include headers it needs, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 09/13] qdev: qdev_create(): use error_report() instead of hw_error(),
Andreas Färber <=
- [Qemu-devel] [PATCH 08/13] sysemu.h: Include qemu-types.h instead of qemu-common.h, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 07/13] Create qemu-types.h for struct typedefs, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 13/13] target-i386: Postpone cpuid_level update to realize time, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 10/13] target-i386/cpu.c: Coding style fixes, Andreas Färber, 2012/12/06
- [Qemu-devel] [PATCH 12/13] target-i386: Use define for cpuid vendor string size, Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06, Andreas Färber, 2012/12/07