Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

[Luiz Capitulino]

On Fri, 7 Dec 2012 11:47:24 -0600
mdroth <address@hidden> wrote:

> On Fri, Dec 07, 2012 at 11:55:16AM -0200, Luiz Capitulino wrote:
> > On Fri, 07 Dec 2012 17:39:32 +0900
> > Tomoki Sekiyama <address@hidden> wrote:
> > 
> > > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> > >   - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
> > >   - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot
> > > 
> > > Signed-off-by: Tomoki Sekiyama <address@hidden>
> > > ---
> > >  .gitignore                                         |    1 
> > >  Makefile                                           |    2 -
> > >  scripts/qemu-guest-agent/fsfreeze-hook             |   33 ++++++++++++
> > >  .../fsfreeze-hook.d/mysql-flush.sh.sample          |   55 
> > > ++++++++++++++++++++
> > >  4 files changed, 90 insertions(+), 1 deletion(-)
> > >  create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook
> > >  create mode 100755 
> > > scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
> > > 
> > > diff --git a/.gitignore b/.gitignore
> > > index bd6ba1c..286822d 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -93,3 +93,4 @@ cscope.*
> > >  tags
> > >  TAGS
> > >  *~
> > > +!scripts/qemu-guest-agent/fsfreeze-hook.d
> > 
> > Why? Do we expect to have *~ files in there?
> 
> I think default vim configurations will copy <file> to <file>~ prior to
> editing.

But should that be tracked by git specifically in that dir?

> > > diff --git a/Makefile b/Makefile
> > > index 9ecbcbb..466dcd7 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -248,7 +248,7 @@ clean:
> > >  # avoid old build problems by removing potentially incorrect old files
> > >   rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h 
> > > gen-op-arm.h
> > >   rm -f qemu-options.def
> > > - find . -name '*.[od]' -exec rm -f {} +
> > > + find . -name '*.[od]' -type f -exec rm -f {} +
> > 
> > What does this change have to do with this patch?
> 
> Looks like it'll try (and fail, due to lack of -r option to rm) to
> delete the fsfreeze-hook.d directory on `make clean`. For in-tree builds
> at least.

I can't see it, but well, I don't want to hold this patch for minor things
either... It looks good for me apart from these two nitpicks.