Re: [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64

[Andreas Färber]

Am 07.12.2012 22:52, schrieb Richard Henderson:
> The interface to normalizeRoundAndPackFloat64 requires that the
> high bit be clear.  Perform one shift-right-and-jam if needed.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  fpu/softfloat.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 8413146..62830d7 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1273,9 +1273,14 @@ float64 int64_to_float64( int64 a STATUS_PARAM )
>  
>  float64 uint64_to_float64( uint64 a STATUS_PARAM )
>  {
> -    if ( a == 0 ) return float64_zero;
> -    return normalizeRoundAndPackFloat64( 0, 0x43C, a STATUS_VAR );
> +    int exp =  0x43C;

Extra space before number.

>  
> +    if ( a == 0 ) return float64_zero;
> +    if ( (int64_t)a < 0 ) {
> +        shift64RightJamming(a, 1, &a);
> +        exp += 1;
> +    }
> +    return normalizeRoundAndPackFloat64( 0, exp, a STATUS_VAR );
>  }
>  
>  
> /*----------------------------------------------------------------------------

Shouldn't we be updating the Coding Style on all lines we touch? The
shift line matches it but the normalize and ifs don't.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg