Re: [Qemu-devel] [PATCH 01/19] openpic: Remove unused code

[Alexander Graf]

On 08.12.2012, at 16:12, Andreas Färber wrote:

> Am 08.12.2012 14:44, schrieb Alexander Graf:
>> The openpic code had a few WIP bits left that nobody reanimated within
>> the last few years. Remove that code.
>> 
>> Signed-off-by: Alexander Graf <address@hidden>
> 
> Reviewed-by: Andreas Färber <address@hidden>
> 
> I'm not aware of any GW80314 users, CC'ing Hervé just to be sure.
> The BeBox has an i82378 (sitting on its MPC105), using i8259 PICs.
> 
> But even if there were something using them, this is most definitely the
> wrong way to model variations nowadays. :)
> 
> Alex, did you find out what was broken about it?

I don't even know what model was supposed to ever use this. IIUC most of that 
code was for the Intel OpenPIC flavor (whichever one that is). So it's really 
more about untestable code rather than it being broken.

I'd say if anyone wants to introduce a board that requires these bits, I'm more 
than happy to see them added back in in a properly modeled way :)


Alex