Re: [Qemu-devel] [PATCH] linux-user: correctly align types in thunking code

[Andreas Färber]

Am 08.12.2012 16:18, schrieb Laurent Vivier:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  thunk.h |   22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/thunk.h b/thunk.h
> index 87025c3..d3e9f3d 100644
> --- a/thunk.h
> +++ b/thunk.h
> @@ -151,20 +151,32 @@ static inline int thunk_type_align(const argtype 
> *type_ptr, int is_host)
>      case TYPE_CHAR:
>          return 1;
>      case TYPE_SHORT:
> -        return 2;
> +        if (is_host) {
> +            return __alignof__(short);

Might __alignof__() depend on a certain GCC version? Is it supported by
clang?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg