[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/19] MSI-X: Fix endianness
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 19/19] MSI-X: Fix endianness |
Date: |
Sun, 9 Dec 2012 00:41:55 +0200 |
On Sat, Dec 08, 2012 at 02:44:42PM +0100, Alexander Graf wrote:
> The MSI-X vector tables are usually stored in little endian in memory,
> so let's mark the accessors as such.
>
> This fixes MSI-X on e500 for me.
>
> Signed-off-by: Alexander Graf <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/msix.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/msix.c b/hw/msix.c
> index 136ef09..b57ae60 100644
> --- a/hw/msix.c
> +++ b/hw/msix.c
> @@ -180,8 +180,7 @@ static void msix_table_mmio_write(void *opaque, hwaddr
> addr,
> static const MemoryRegionOps msix_table_mmio_ops = {
> .read = msix_table_mmio_read,
> .write = msix_table_mmio_write,
> - /* TODO: MSIX should be LITTLE_ENDIAN. */
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> .valid = {
> .min_access_size = 4,
> .max_access_size = 4,
> @@ -198,8 +197,7 @@ static uint64_t msix_pba_mmio_read(void *opaque, hwaddr
> addr,
>
> static const MemoryRegionOps msix_pba_mmio_ops = {
> .read = msix_pba_mmio_read,
> - /* TODO: MSIX should be LITTLE_ENDIAN. */
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> .valid = {
> .min_access_size = 4,
> .max_access_size = 4,
> --
> 1.6.0.2
- [Qemu-devel] [PATCH 00/19] OpenPIC refactoring and MSI support, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 04/19] openpic: combine mpic and openpic src handlers, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 10/19] openpic: remove unused type variable, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 19/19] MSI-X: Fix endianness, Alexander Graf, 2012/12/08
- Re: [Qemu-devel] [PATCH 19/19] MSI-X: Fix endianness,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 15/19] openpic: make brr1 model specific, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 07/19] openpic: merge mpic and openpic timer handling, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 03/19] openpic: update to proper memory api, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 13/19] openpic: remove irq_out, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 05/19] openpic: Convert subregions to memory api, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 11/19] openpic: convert simple reg operations to builtin bitops, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 18/19] PPC: e500: Declare pci bridge as bridge, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 17/19] PPC: e500: Add MSI support, Alexander Graf, 2012/12/08
- [Qemu-devel] [PATCH 01/19] openpic: Remove unused code, Alexander Graf, 2012/12/08