Re: [Qemu-devel] [PATCHv6] rbd block driver fix race between aio completition and aio cancel

[Kevin Wolf]

Am 30.11.2012 14:50, schrieb Stefan Hajnoczi:
> On Fri, Nov 30, 2012 at 9:55 AM, Stefan Priebe <address@hidden> wrote:
>> This one fixes a race which qemu had also in iscsi block driver
>> between cancellation and io completition.
>>
>> qemu_rbd_aio_cancel was not synchronously waiting for the end of
>> the command.
>>
>> To archieve this it introduces a new status flag which uses
>> -EINPROGRESS.
>>
>> Changes since PATCHv5:
>> - qemu_aio_release has to be done in qemu_rbd_aio_cancel if I/O
>>   was cancelled
>>
>> Changes since PATCHv4:
>> - removed unnecessary qemu_vfree of acb->bounce as BH will always
>>   run
>>
>> Changes since PATCHv3:
>> - removed unnecessary if condition in rbd_start_aio as we
>>   haven't start io yet
>> - moved acb->status = 0 to rbd_aio_bh_cb so qemu_aio_wait always
>>   waits until BH was executed
>>
>> Changes since PATCHv2:
>> - fixed missing braces
>> - added vfree for bounce
>>
>> Signed-off-by: Stefan Priebe <address@hidden>
>>
>> ---
>>  block/rbd.c |   20 ++++++++++++--------
>>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks, applied to the block branch.

For future patches, please put a "---" line between the real commit
message (including the SoB, of course) and the changelog so that git am
automatically removes the changelog.

Kevin