Re: [Qemu-devel] [PATCH_v3] add target-openrisc floating point exception

[Wei-Ren Chen]

Hi Feng,

  One question,

> @@ -25,5 +25,5 @@  void HELPER(exception)(CPUOpenRISCState *env,
> uint32_t excp)
>  {
>      OpenRISCCPU *cpu = OPENRISC_CPU(ENV_GET_CPU(env));
>  
> -    raise_exception(cpu, excp);
> +    do_raise_exception(cpu, excp, 0);
>  }

  Shouldn't above helper function be called from the code cache?
The 3rd argument of do_raise_exception means if the exception comes
from code cache or not, iiuc. Is it correct to put zero here?

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj