Re: [Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output

[Gerd Hoffmann]

On 12/11/12 09:57, Stefan Hajnoczi wrote:
> On Mon, Dec 10, 2012 at 03:54:58PM -0000, Tim Hardeck wrote:
>> 47683d669f993308c2b84bed4ce64aafb5d7ced4 is the first bad commit
>> commit 47683d669f993308c2b84bed4ce64aafb5d7ced4
>> Author: Gerd Hoffmann <address@hidden>
>> Date:   Thu Oct 11 12:04:33 2012 +0200
>>
>>     pixman/vnc: remove rgb_prepare_row* functions
>>
>>     Let pixman do it instead.
>>
>>     Signed-off-by: Gerd Hoffmann <address@hidden>
>>
>> :040000 040000 653d58e66bf3a2d8240b2f9176979c44ccd720e1
>> 6b6e367a8522cb58b42ad8f204387a354d3b3d00 M  ui
>>
>>
>> Just reverting this particular commit isn't enough thou but it is connected.
> 
> This suggests the conversion to pixman has introduced the bug.

Quite possible.  I've tested tight via 'vncviewer
PreferredEncoding=Tight', but that doesn't force png, so there is a
chance for issues I havn't seen.

> Tim: can you provide steps to reproduce the bug?

That will certainly help fixing.

Also: How garbled?  Totally messed up?  Just colors wrong?  Any other
visible pattern?

cheers,
  Gerd