[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats |
Date: |
Tue, 11 Dec 2012 09:45:13 -0200 |
On Tue, 11 Dec 2012 05:12:29 +0000
Dietmar Maurer <address@hidden> wrote:
> Can't we enable stat queries by default (10s interval),
I'm not sure I like this for two reasons. First, there will be cases where
the user doesn't want this to be enabled. Second, we'll be forcing an interval
on users.
> and simply return all stats with one API call (query-ballon)?
We can't use query-balloon because this changes query-balloon from
synchronous to asynchronous, and this is an incompatible change.
Now, adding a new command to do this was my first proposal on this:
http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg00983.html
But Anthony suggested doing this through qom, which I agree that is a
simpler & cleaner interface.
> That qom-get interface forces me to do 6 API calls to get all information!
Does this really matter for an application?
>
> > -----Original Message-----
> > From: address@hidden
> > [mailto:address@hidden On
> > Behalf Of Luiz Capitulino
> > Sent: Montag, 10. Dezember 2012 20:36
> > To: address@hidden
> > Cc: address@hidden; address@hidden; address@hidden
> > Subject: [Qemu-devel] [PATCH 0/3] re-enable balloon stats
> >
> > This new try to re-enable the virtio-balloon driver stats uses QOM
> > properties
> > via a polling mechanism as suggested by Anthony here:
> >
> > http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html
> >
> > o Changes from the rfc
> >
> > - avoid balloon_stats_poll_cb() and virtio_balloon_handle_output()
> > running in parallel
> > - small renames and re-writes for better readability
> > - update documentation
> >
> > Luiz Capitulino (3):
> > virtio-balloon: drop old stats code
> > virtio-balloon: re-enable balloon stats
> > docs: document virtio-balloon stats
> >
> > docs/virtio-balloon-stats.txt | 87 +++++++++++++++++++
> > hw/virtio-balloon.c | 189 ++++++++++++++++++++++++++++++++++++---
> > ---
> > 2 files changed, 252 insertions(+), 24 deletions(-) create mode 100644
> > docs/virtio-balloon-stats.txt
> >
> > --
> > 1.8.0
> >
>
>
- [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Luiz Capitulino, 2012/12/10
- [Qemu-devel] [PATCH 2/3] virtio-balloon: re-enable balloon stats, Luiz Capitulino, 2012/12/10
- [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats, Luiz Capitulino, 2012/12/10
- [Qemu-devel] [PATCH 1/3] virtio-balloon: drop old stats code, Luiz Capitulino, 2012/12/10
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Dietmar Maurer, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Dietmar Maurer, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Luiz Capitulino, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Dietmar Maurer, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, mdroth, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Luiz Capitulino, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Luiz Capitulino, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Dietmar Maurer, 2012/12/11
- Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats, Luiz Capitulino, 2012/12/11