qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features a


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time
Date: Tue, 11 Dec 2012 12:25:47 -0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 11, 2012 at 03:08:56PM +0100, Igor Mammedov wrote:
[...]
> > > +    /* On AMD CPUs, some CPUID[8000_0001].EDX bits must match the bits on
> > > +     * CPUID[1].EDX.
> > > +     */
> > > +    if (env->cpuid_vendor1 == CPUID_VENDOR_AMD_1 &&
> > > +        env->cpuid_vendor2 == CPUID_VENDOR_AMD_2 &&
> > > +        env->cpuid_vendor3 == CPUID_VENDOR_AMD_3) {
> > 
> > I would add extra indentation space here, to make it not align with the
> > statements below, making the condition visually distinct from the body,
> > like in the original code you are moving.
> I've thought people would object to ident here, that's why I've changed
> original indentation to a more consistent with rules.
> 
> BTW: git grep -A 3 "if (.*[^{)]$"
> shows that many places use this style including fairly recent ones:
> aio-posix.c first hit
> 
> and we have in target-i386/cpu.c
> if (x86_cpu_def->vendor1 == CPUID_VENDOR_VIA_1 &
> ...
> with the same alignment style and at least one more similar.
> Lets leave it this way to be consistent with the rest of the code.

No problem. I was expressing personal preference, not knowing what was
the preferred/usual style in QEMU. My only data point was the original
code you moved.  :-)

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]