[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID,
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt |
Date: |
Wed, 12 Dec 2012 15:51:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Il 12/12/2012 15:48, Michael S. Tsirkin ha scritto:
>>>>> > >> > diff --git a/hw/pci.h b/hw/pci.h
>>>>> > >> > index 0719521..3704d5f 100644
>>>>> > >> > --- a/hw/pci.h
>>>>> > >> > +++ b/hw/pci.h
>>>>> > >> > @@ -78,6 +78,7 @@
>>>>> > >> > #define PCI_DEVICE_ID_VIRTIO_SCSI 0x1004
>>>>> > >> > #define PCI_DEVICE_ID_VIRTIO_RNG 0x1005
>>>>> > >> > #define PCI_DEVICE_ID_VIRTIO_9P 0x1009
>>>>> > >> > +#define PCI_DEVICE_ID_QUMRANET_IVSHMEM 0x1110
>>>>> > >> >
>>>>> > >> > #define FMT_PCIBUS PRIx64
>>> > > Why _QUMRANET I wonder?
>>> > >
>> >
>> > Because it's under 0x1af4 (PCI_VENDOR_ID_REDHAT_QUMRANET), not 0x1b36
>> > (PCI_VENDOR_ID_REDHAT).
>
> Yes but so are all virtio devices are they not?
All device IDs start with PCI_DEVICE_ID_<vendor>. virtio devices are
the exception for some historical reason I don't know.
PCI_DEVICE_ID_VIRTIO_IVSHMEM is wrong, and PCI_DEVICE_ID_IVSHMEM is
unspecific. PCI_DEVICE_ID_QEMU_IVSHMEM is wrong because the QEMU vendor
id is 0x1234.
So either it stays Qumranet, or the 0x1234 vendor id is renamed to
PCI_VENDOR_ID_BOCHS and 0x1af4 becomes PCI_VENDOR_ID_REDHAT_QEMU.
Either is fine for me, but I wanted to minimize the churn.
Paolo
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt, Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt, Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt, Michael S. Tsirkin, 2012/12/12