Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

[Alexander Graf]

On 12/12/2012 04:05 PM, Viktor Mihajlovski wrote:
> On 12/12/2012 02:51 PM, Andreas Färber wrote:
> > > +    (*cpu_fprintf)(f, "s390 %16s\n", "[host]");
> >
> > Note that the square-bracket notation was specific to x86 when it
> > distinguished between built-in and config-based models.
> OK, since libvirt capable of dealing with s390 cpu models will
> never see this, we can change it any way that is wanted.
> So, host without brackets?
> > "host" only makes sense for KVM, not for TCG. So we would need one other
> > placeholder model for libvirt.
> see my reply to Alex' comment: the placeholder name must be chosen
> carefully, i.e. future-proof

Yeah, it's perfectly fine for me to ignore the model name in the code 
today (as we do iirc) and only add the host target for starters. Though 
that one should do a kvm_enabled() check.


Alex