[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if to
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified |
Date: |
Thu, 13 Dec 2012 14:17:34 +0000 |
On 13 December 2012 13:19, Alexander Graf <address@hidden> wrote:
>
> On 13.12.2012, at 14:17, David Gibson wrote:
>
>> On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote:
>>> What if I am using TCG on PPC?
>>
>> Then the stub version of kvmppc_smt_threads() returns 1, and since the
>> PPC TCG doesn't do any SMT emulation, that would seem to be correct...
>
> int kvmppc_smt_threads(void)
> {
> return cap_ppc_smt ? cap_ppc_smt : 1;
> }
>
> So because we don't call kvm_arch_init, the cap is 0 and thus we return 1?
No, if we aren't CONFIG_KVM then that source file and version of
the function aren't compiled at all. David means the stub
function, which is in kvm_ppc.h:
static inline int kvmppc_smt_threads(void)
{
return 1;
}
(if you don't like stubs lurking in the header file you could
have a target-ppc/kvm-stub.c by analogy with the i386 one I suppose)
-- PMM
- [Qemu-devel] [0/13] Pending pseries/ppc patches as at 1.3 release, David Gibson, 2012/12/03
- [Qemu-devel] [PATCH 03/13] pseries: Return the token when we register an RTAS call, David Gibson, 2012/12/03
- [Qemu-devel] [PATCH 06/13] pseries: Split xics irq configuration from state information, David Gibson, 2012/12/03
- [Qemu-devel] [PATCH 01/13] pseries: Fix incorrect initialization of interrupt controller, David Gibson, 2012/12/03
- [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, David Gibson, 2012/12/03
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, David Gibson, 2012/12/03
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, David Gibson, 2012/12/13
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, Peter Maydell, 2012/12/13
- Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified, David Gibson, 2012/12/16
[Qemu-devel] [PATCH 07/13] pseries: Implement PAPR NVRAM, David Gibson, 2012/12/03
[Qemu-devel] [PATCH 12/13] pseries: Increase default NVRAM size, David Gibson, 2012/12/03
[Qemu-devel] [PATCH 04/13] pseries: Allow RTAS tokens without a qemu handler, David Gibson, 2012/12/03
[Qemu-devel] [PATCH 11/13] pseries: Fixes and enhancements to L1 cache properties, David Gibson, 2012/12/03