Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

[Alexander Graf]

On 13.12.2012, at 15:48, Gerd Hoffmann wrote:

> On 12/13/12 15:31, Alexander Graf wrote:
>> 
>> On 10.12.2012, at 13:48, Gerd Hoffmann wrote:
>> 
>>> Lower the bar a bit.  0.16.4 is known-good, and is shipped by
>>> debian. Fixes build failures on the debian-based buildbot slaves.
>> 
>> SLES11 ships 0.16.0 for example. It'd be nice to stay compatible
>> there.
> 
> If 0.16.0 is known good we can pick that one.
> 
>> What exactly is the compatibility bar? The fact that it compiles?
>> Without the configure check it's compiling just fine on 0.12.0
>> (openSUSE 11.1) here.
> 
> Hmm,  /me saw reports of *not* building with 0.12.0, which was the
> reason to add this in the first place ...

Yeah, check out

  6e72719e721a40fe1224701ca10edc1caf0cd708

You had 2 branches that were using a new flag, one of which you had an #ifdef 
around and one of which you didn't. This is all fixed for quite a while now :).

If that's the culprit for all this mess, can we remove the configure check 
again? QEMU compiles just fine without it today on pixman 0.12.0.


Alex