Re: [Qemu-devel] [PATCH 2/3] qtest: extend qtest_qmp() to fill in the reply

[Andreas Färber]

Am 13.12.2012 23:02, schrieb Jason Baron:
> diff --git a/tests/Makefile b/tests/Makefile
> index b60f0fb..30a101d 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -74,10 +74,10 @@ tests/test-qmp-input-strict$(EXESUF): 
> tests/test-qmp-input-strict.o $(test-qapi-
>  tests/test-qmp-commands$(EXESUF): tests/test-qmp-commands.o 
> tests/test-qmp-marshal.o $(test-qapi-obj-y)
>  tests/test-visitor-serialization$(EXESUF): 
> tests/test-visitor-serialization.o $(test-qapi-obj-y)
>  
> -tests/rtc-test$(EXESUF): tests/rtc-test.o $(trace-obj-y)
> +tests/rtc-test$(EXESUF): tests/rtc-test.o $(trace-obj-y) qstring.o
>  tests/m48t59-test$(EXESUF): tests/m48t59-test.o $(trace-obj-y)
> -tests/fdc-test$(EXESUF): tests/fdc-test.o tests/libqtest.o $(trace-obj-y)
> -tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o tests/libqtest.o 
> $(trace-obj-y)
> +tests/fdc-test$(EXESUF): tests/fdc-test.o tests/libqtest.o $(trace-obj-y) 
> qstring.o
> +tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o tests/libqtest.o 
> $(trace-obj-y) qstring.o

Adding a dependency to every qtest is calling for a $(qtest-obj-y) to
administer that list in a central location. I am expecting the number of
tests to grow significantly over time.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg