qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers a


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed
Date: Fri, 14 Dec 2012 02:51:02 -0500 (EST)

> > We technically should save the addresses and sizes too.  It makes
> > it a heck of a lot safer then re-reading guest memory since we do some
> > validation on the size of the sg elements.
> 
> Not really.
> 
> The guest puts the descriptors in the ring and leaves them there until
> the device acks.  If it changes them once they're exposed but before
> they're acked, it can get either before or after version, and always
> could.

The problems start when the guest tries to race against QEMU and defy
the validation.  Always using the validated version is a bit easier
than redoing the validation after migration.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]