[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers a
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed |
Date: |
Fri, 14 Dec 2012 02:51:02 -0500 (EST) |
> > We technically should save the addresses and sizes too. It makes
> > it a heck of a lot safer then re-reading guest memory since we do some
> > validation on the size of the sg elements.
>
> Not really.
>
> The guest puts the descriptors in the ring and leaves them there until
> the device acks. If it changes them once they're exposed but before
> they're acked, it can get either before or after version, and always
> could.
The problems start when the guest tries to race against QEMU and defy
the validation. Always using the validated version is a bit easier
than redoing the validation after migration.
Paolo
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, (continued)
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Anthony Liguori, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Rusty Russell, 2012/12/13
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Anthony Liguori, 2012/12/16
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Paolo Bonzini, 2012/12/13
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Kevin Wolf, 2012/12/13
- Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/16
Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed, Michael S. Tsirkin, 2012/12/12