qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version
Date: Fri, 14 Dec 2012 10:57:43 +0100


On 14.12.2012, at 08:54, Gerd Hoffmann <address@hidden> wrote:

>  Hi,
> 
>>> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708
>>> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
>> 
>> 6e72719 is perfectly sane, because it brings consistency into the
>> file. Now both users of PIXMAN_TYPE_BGRA are guarded by the same
>> #ifdef.
> 
> Both users?  Hello?  Its two *different* types: PIXMAN_TYPE_RGBA and
> PIXMAN_TYPE_BGRA.  And, yes, they have been added in different versions.
> So guarding them with the *same* #ifdef is wrong.

Ugh :(. Sorry then.

> 
>> #ifdef PIXMAN_TYPE_BGRA
> 
> It's a enum, not a #define, so this isn't going to fly.

In my old versions it's a define...


Alex

> 
> cheers,
>  Gerd
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]