Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

[Eduardo Habkost]

On Fri, Dec 14, 2012 at 04:44:24PM +0100, Andreas Färber wrote:
> Am 14.12.2012 16:40, schrieb Paolo Bonzini:
> > Il 14/12/2012 16:29, Andreas Färber ha scritto:
> >> The latest motivation for making the CPU a device was to have the static
> >> properties infrastructure for machine/CPU versioning. The global
> >> property defaults are set in qdev's instance_init, so object_new() seems
> >> fine for that.
> >>
> >> qdev_[try_]create() would further set the parent bus to SysBus if NULL.
> >> The CPU is not a SysBusDevice so I think not using qdev_create() may be
> >> safer... Maybe Anthony or Paolo can confirm?
> > 
> > I think various parts of qdev assume there is a bus, so actually using
> > SysBus would be safer (though uglier).
> 
> Hm, Anthony told me with one of his qbus refactoring patches back in
> qom-next the last remaining assumptions (info qdm) were removed...
> 
> Probably we're the first to test though. ;)

BTW, we're also not including SysBus, on *-user.

-- 
Eduardo