[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState |
Date: |
Fri, 14 Dec 2012 15:56:33 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Dec 14, 2012 at 04:44:24PM +0100, Andreas Färber wrote:
> Am 14.12.2012 16:40, schrieb Paolo Bonzini:
> > Il 14/12/2012 16:29, Andreas Färber ha scritto:
> >> The latest motivation for making the CPU a device was to have the static
> >> properties infrastructure for machine/CPU versioning. The global
> >> property defaults are set in qdev's instance_init, so object_new() seems
> >> fine for that.
> >>
> >> qdev_[try_]create() would further set the parent bus to SysBus if NULL.
> >> The CPU is not a SysBusDevice so I think not using qdev_create() may be
> >> safer... Maybe Anthony or Paolo can confirm?
> >
> > I think various parts of qdev assume there is a bus, so actually using
> > SysBus would be safer (though uglier).
>
> Hm, Anthony told me with one of his qbus refactoring patches back in
> qom-next the last remaining assumptions (info qdm) were removed...
>
> Probably we're the first to test though. ;)
BTW, we're also not including SysBus, on *-user.
--
Eduardo
- [Qemu-devel] [PATCH 5/8] qdev: Coding style fixes, (continued)
- [Qemu-devel] [PATCH 5/8] qdev: Coding style fixes, Eduardo Habkost, 2012/12/05
- [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Eduardo Habkost, 2012/12/05
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Andreas Färber, 2012/12/12
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Eduardo Habkost, 2012/12/12
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Igor Mammedov, 2012/12/12
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Eduardo Habkost, 2012/12/12
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Andreas Färber, 2012/12/14
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, Andreas Färber, 2012/12/14
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState,
Eduardo Habkost <=
[Qemu-devel] [PATCH 7/8] include qdev code into *-user, too, Eduardo Habkost, 2012/12/05
[Qemu-devel] [PATCH 3/8] libqemustub: vmstate register/unregister stubs, Eduardo Habkost, 2012/12/05
[Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs, Eduardo Habkost, 2012/12/05
[Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/12/05