[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu ins
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances |
|
Date: |
Sat, 15 Dec 2012 04:14:14 -0500 (EST) |
> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock"
> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp"
> > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid"
>
> These filenames are too predictable from security point of view,
This need not be secure as long as the file is created with 0600
permissions. In fact, inspecting the pid file from the shell can
be useful.
However, using mkstemp() on a prefix that includes the parent pid
can indeed be the best of both worlds.
Paolo
[Qemu-devel] [PATCH 3/3] qtest: add migrate-test, Jason Baron, 2012/12/13