qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO
Date: Sat, 15 Dec 2012 06:05:34 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 12/15/2012 02:09 AM, Paolo Bonzini wrote:

>>> +    /* Allocate a MirrorOp that is used as an AIO callback.  */
>>> +    op = g_slice_new(MirrorOp);
>>> +    op->s = s;
>>> +    op->iov.iov_base = s->buf;
>>> +    op->iov.iov_len  = nb_sectors * 512;
>>
>> Why two spaces?
> 
> To align the equal signs. :)

Then I didn't quote enough context.  Why the two spaces here, when the
very next line didn't align equal signs?

> 
> +    op->s = s;
> +    op->iov.iov_base = s->buf;
> +    op->iov.iov_len  = nb_sectors * 512;
> +    op->sector_num = sector_num;
> +    op->nb_sectors = nb_sectors;

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]