Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

[Luiz Capitulino]

On Mon, 17 Dec 2012 10:13:40 +0000
Dietmar Maurer <address@hidden> wrote:

> > Next commit will re-enable balloon stats with a different interface, but 
> > this
> > old code conflicts with it. Let's drop it.
> 
> I don't really see any conflicts here?

query-balloon resets all stats to -1. So, if it's issued after the stats have
been polled all values are lost.

> > It's important to note that the QMP and HMP interfaces are also dropped by
> > this commit. That shouldn't be a problem though, because:
> > 
> >  1. All QMP fields are optional
> >  2. This has never been really used
> 
> Why don't we simply implement the missing parts - it's just a few lines of 
> code.

For the reasons explained in my last email. We'd need at least two commands,
one for to enable polling/set time interval and also query-balloon-stats,
as adding this to query-balloon would mix semantics (ie. one field is always
there and the others have polling semantics).