Re: [Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI EHCI split

[Gerd Hoffmann]

On 12/16/12 04:49, Andreas Färber wrote:
> SysBus EHCI was introduced in a hurry before 1.3 Soft Freeze.
> To use QOM casts in place of DO_UPCAST() / FROM_SYSBUS(), we need an
> identifying type. Introduce generic abstract base types for PCI and
> SysBus EHCI to allow multiple types to access the shared fields.
> 
> While at it, move the state structs being amended with macros to the
> header file so that they can be embedded.

--verbose please.

I fail to see the point.  EHCIPCIState should not be needed outside of
hcd-ehci-pci.c and I'd prefer to leave it there.  Likewise for sysbus.

cheers,
  Gerd