Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

[Alexander Graf]

On 17.12.2012, at 15:05, Markus Armbruster wrote:

> They complicate IDE data structures and keep getting in the way.
> Also, TRIM support (commit d353fb72) is broken for them, because
> ide_identify() accesses IDEDevice member conf, but IDEDevice exists
> only with qdevified controllers.
> 
> The non-qdevified controllers are still there, but attempting to
> connect devices to them fails with "IDE controller not qdevified yet;
> drive <name> ignored".
> 
> Affected machines:
> 
> * g3beige's first IDE channel (MacIO)
>  -hda, -hdb are on first channel, and no longer work
>  -hdc, -hdd are on second channel, and still work
> * mac99's second and third IDE channel (MacIO)
>  All four IDE drives no longer work

Nack. This breaks the default targets of qemu-system-ppc and qemu-system-ppc64.


Alex