Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

[Andreas Färber]

Am 17.12.2012 19:21, schrieb Paolo Bonzini:
> Il 17/12/2012 18:55, Andreas Färber ha scritto:
>> Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
>>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>>> index 3ea4140..63ae888 100644
>>> --- a/hw/virtio-pci.c
>>> +++ b/hw/virtio-pci.c
>>> @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void);
>>>  
>>>  /* virtio device */
>>>  
>>> -static void virtio_pci_notify(void *opaque, uint16_t vector)
>>> +static void virtio_pci_notify(DeviceState *d, uint16_t vector)
>>>  {
>>> -    VirtIOPCIProxy *proxy = opaque;
>>> +    VirtIOPCIProxy *proxy = container_of(d, VirtIOPCIProxy, pci_dev.qdev);
>>
>> Nack. This is going the wrong direction QOM-wise and you among all
>> others know that from PCI host bridges!
> 
> Well, that's just a difference of VIRTIO_PCI_PROXY(d) vs. container_of.

VIRTIO_PCI_PROXY(d) would be acceptable, sure. But as-is this patch just
pushes unnecessary work on Fred, me, you or anyone else who works with QOM.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg