Re: [Qemu-devel] [PATCH 00/20 v2] x86 CPU cleanup (wave 2)

[Igor Mammedov]

On Mon, 17 Dec 2012 21:43:33 +0100
Andreas Färber <address@hidden> wrote:

> Am 17.12.2012 17:01, schrieb Igor Mammedov:
> > This series is several cleanups, moved out from CPU properties series,
> > since they do not really depend on CPU properties re-factoring and could
> > simplify CPU subclasses work as well.
> 
> The initial cleanups (most of which I had already reviewed) look
> promising. But some others are working around issues that subclasses
> solve. And I would like to keep functional changes visible.
Could you be more specific, please?

This series is aimed to separate as much as possible (without converting
everything to properties first) initial CPU initialization from a found
cpu-model /will become classes/ and user supplied values for features which
will be gradually transformed to canonical form of key,value pairs and applied
through properties.

Following on cpu properties series is going property-fy remaining features
that are not properties yet and convert current dynamic properties into 
static properties. It's practically complete, I've just haven't completed
patch-wise testing yet, you can see it here:
https://github.com/imammedo/qemu/tree/x86-cpu-properties.WIP

> If we go and explicitly set the vendor everywhere as you suggest, do we
> even still need the vendor override flag at all?
vendor_override is used on kvm only when user wishes to force
custom vendor value on the guest, built-in models don't do it now, otherwise
guest always gets host's vendor value (see get_cpuid_vendor()).


> 
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
> 


-- 
Regards,
  Igor