Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

[Andreas Färber]

Am 12.12.2012 10:44, schrieb Jan Kiszka:
> On 2012-11-19 15:24, Jan Kiszka wrote:
>> See patches for details.
>>
>> Jan Kiszka (2):
>>   i2c: Introduce device address mask
>>   Add AT24Cxx I2C EEPROM device model
>>
>>  hw/Makefile.objs |    2 +-
>>  hw/at24.c        |  363 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  hw/ds1338.c      |    2 +-
>>  hw/i2c.c         |    9 +-
>>  hw/i2c.h         |    3 +-
>>  hw/lm832x.c      |    2 +-
>>  hw/max7310.c     |    2 +-
>>  hw/pxa2xx.c      |    3 +-
>>  hw/smbus.c       |    2 +-
>>  hw/ssd0303.c     |    2 +-
>>  hw/tmp105.c      |    2 +-
>>  hw/tosa.c        |    2 +-
>>  hw/twl92230.c    |    2 +-
>>  hw/wm8750.c      |    2 +-
>>  hw/z2.c          |    2 +-
>>  15 files changed, 383 insertions(+), 17 deletions(-)
>>  create mode 100644 hw/at24.c
>>
> 
> Ping. Both still apply over latest master, and addressable review
> comments are not pending according to my understanding.

Hello Jan, did you see my recent proposal of an I2C qtest framework? :)
For one I'd be interested in feedback from someone who knows I2C and for
another maybe you could follow-up your patch with some test case (I2C
master shouldn't matter, I guess).

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg