[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward de
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups() |
Date: |
Tue, 18 Dec 2012 17:51:15 +0100 |
From: John Spencer <address@hidden>
this declaration is wrong:
the correct prototype on linux is:
int setgroups(size_t size, const gid_t *list);
since by default musl libc exposes this symbol in unistd.h
additionally to grp.h, the wrong declaration causes a build error.
the proper fix is to simply include the correct header.
Signed-off-by: John Spencer <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 31d5276..275260a 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -28,6 +28,7 @@
#include <fcntl.h>
#include <time.h>
#include <limits.h>
+#include <grp.h>
#include <sys/types.h>
#include <sys/ipc.h>
#include <sys/msg.h>
@@ -584,7 +585,6 @@ extern int personality(int);
extern int flock(int, int);
extern int setfsuid(int);
extern int setfsgid(int);
-extern int setgroups(int, gid_t *);
/* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
#ifdef TARGET_ARM
--
1.8.0.2
- [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 01/10] net, hub: fix the indent in the comments, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 04/10] zynq_slcr: Compile time warning fixes., Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 05/10] arm_gic: Add cpu nr to Raised IRQ message, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 03/10] pflash_cfi0x: Send debug messages to stderr, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 06/10] gitignore: Add virtfs-proxy-helper, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc check, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/10] vmmouse_reset(): remove minimal code duplication, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 10/10] configure: Earlier pkg-config probe, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 02/10] pflash_cfi01: qemu_log_mask "unimplemented" msg, Stefan Hajnoczi, 2012/12/18
- Re: [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012, Anthony Liguori, 2012/12/18