[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 26/26] usbredir: Add support for buffered bulk i
From: |
Hans de Goede |
Subject: |
Re: [Qemu-devel] [PATCH 26/26] usbredir: Add support for buffered bulk input |
Date: |
Wed, 19 Dec 2012 10:27:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Hi,
On 12/18/2012 02:36 PM, Gerd Hoffmann wrote:
Hi,
Added patches 1-25 to the usb queue (using v2 of patch 10).
hw/usb/redirect-ftdi-ids.h | 1255 ++++++++++++++++++++++++++++++++++++++++++
hw/usb/redirect-pl2303-ids.h | 150 +++++
hw/usb/redirect-usb-ids.h | 910 ++++++++++++++++++++++++++++++
Where does this come from? Linux kernel I guess?
These 2 are 1 on 1 copies from the kernel:
hw/usb/redirect-ftdi-ids.h | 1255 ++++++++++++++++++++++++++++++++++++++++++
hw/usb/redirect-pl2303-ids.h | 150 +++++
They contain "boring" stuff like:
#define FTDI_8U232AM_PID 0x6001 /* Similar device to SIO above */
#define FTDI_8U232AM_ALT_PID 0x6006 /* FTDI's alternate PID for above */
Which allows me to easily copy the id tables from the kernel
drivers (.c files).
This one:
hw/usb/redirect-usb-ids.h
Contains the usb-id tables copied from the kernel, as stated
in the comments:
/*
* Silicon Laboratories CP210x USB to RS232 serial adapter ids
* copied from linux/drivers/usb/serial/cp210x.c
*
* Copyright (C) 2005 Craig Shelley (address@hidden)
*/
{ USB_DEVICE(0x045B, 0x0053) }, /* Renesas RX610 RX-Stick */
What is the procedure to update them?
I've defined my own version of the USB_DEVICE macro, after that
the tables are just 1 on 1 copies from the kernel tree, with
s/<tab>/ /
So updating them can be done by emptying the list and then copying in
the new list from the latest kernel, this is an (easy) manual procedure
for now.
I also think this shouldn't be tied to redir, I think it is better to
have a hw/usb/quirks.c file where the device id database and helper
functions to match devices against the list are living.
Makes sense, one problem I see though is that right now I've
2 id tables, named usbredir_raw_serial_ids and usbredir_ftdi_serial_ids
since ftdi based adapters need some extra special handling (a quirk
to the quirk).
Once we start working with quirk tables it makes sense to have 1 large
table with an extra uint32_t field which contains the actual quirks as
bitmask. All perfectly sensible, but this breaks the easy copy and
paste syncing of the tables from the Linux kernel ...
So any good ideas for this from you ?
Regards,
Hans
- [Qemu-devel] [PATCH 17/26] hid: Change idle handling to use a timer, (continued)
- [Qemu-devel] [PATCH 17/26] hid: Change idle handling to use a timer, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 15/26] uhci: Limit amount of frames processed in one go, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 20/26] usbredir: Add an usbredir_stop_ep helper function, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 19/26] usb: Add an usb_device_ep_stopped USBDevice method, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 16/26] uhci: Maximize how many frames we catch up when behind, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 21/26] usbredir: Add USBEP2I and I2USBEP helper macros, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 22/26] usbredir: Add ep_stopped USBDevice method, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 23/26] usbredir: Verify we have 32 bits bulk length cap when redirecting to xhci, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 26/26] usbredir: Add support for buffered bulk input, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 24/26] usbredir: Add usbredir_init_endpoints() helper, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 25/26] usb-redir: Add debugging to bufpq save / restore, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 18/26] usb: Fix usb_ep_find_packet_by_id, Hans de Goede, 2012/12/14