[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances |
Date: |
Fri, 21 Dec 2012 08:47:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Jason Baron <address@hidden> writes:
> On Thu, Dec 20, 2012 at 08:07:02PM +0000, Blue Swirl wrote:
>> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron <address@hidden> wrote:
>> > From: Jason Baron <address@hidden>
[...]
>> > @@ -172,9 +173,11 @@ void qtest_quit(QTestState *s)
>> > unlink(s->pid_file);
>> > unlink(s->socket_path);
>> > unlink(s->qmp_socket_path);
>> > + unlink(s->tmp_dir);
>>
>> -EISDIR, rmdir() would be needed instead.
>>
>
> 'unlink()' tested fine on Linux. But yes, it might not be as portable.
s/might not be as/isn't/
SUSv7:
[EPERM]
The file named by path is a directory, and either the calling
process does not have appropriate privileges, or the implementation
prohibits using unlink() on directories.
[...]