Re: [Qemu-devel] [PULL 00/34] migration thread and queue

[Paolo Bonzini]

Il 21/12/2012 01:27, Anthony Liguori ha scritto:
> #!/bin/sh
> 
> gzip -d -c lidb.ssmall.img.gz | \
>     ~/build/qemu/x86_64-softmmu/qemu-system-x86_64 -cdrom \
>     ~/isos/OCDC-lucid-Test-Drive-20110523_140333.iso -enable-kvm -m 2G \
>     -incoming exec:dd
> 
> With lidb.ssmall.img.gz being generated from a 'migrate exec:dd of=...'
> from qemu.git just a week or two ago.

So it breaks *incoming* migration, which would restrict the problem to
the beginning of the patch (reorganization of the RAM block list).
Everything else touches only outgoing migration.

However, I tested bidirectional migration between origin/master and
Juan's branch and it passed

  x86_64-softmmu/qemu-system-x86_64 \
    -drive if=virtio,cache=none,file=/../images/jeos-17-64.qcow2 \
    -vnc :1 -incoming "exec:cat foo" --enable-kvm

I also tested both my and Juan's branches and they both pass all
migration tests.

> I can't bisect tonight but can attempt to tomorrow.  How has this been
> tested?

Indeed old->new and new->old migration wasn't tested AFAIK.  Not by me
at least.

Paolo

> I'm a little concerned here about the timing.  With the Christmas
> and New Years holiday we're pretty darn close to soft freeze for 1.4.
> 
> Has this series gone through a full autotest run with multiple guests?