[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command |
Date: |
Fri, 21 Dec 2012 11:17:27 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 12/21/2012 07:49 AM, Markus Armbruster wrote:
>>> +static const mon_cmd_t *monitor_parse_command(Monitor *mon,
>>> + const char *cmdline,
>>> + const mon_cmd_t *table,
>>> + QDict *qdict);
>>
>> Please, move the function instead.
>
> Move will make review harder. I don't mind forward declarations.
If you do move the function, then split this into two patches - one for
JUST the code motion, and another that adds the 'table' argument to the
function.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 3/3] HMP: show internal snapshots on a single device, Wenchao Xia, 2012/12/19